Skip to contentSkip to conversation

Change in openvpn[master]: Fix doxygen warnings in crypto_epoch.h

Openvpn-devel In review flichtenheld (Code Review) 2 participants 6 messages Jan 27, 2025 – Jan 29, 2025 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): gerrit.1737980858000.I0133085ac68f7b0db574b88276f6d5e1d3ad62d5@...2715...

#1 lore raw

Attention is currently required from: plaisthos.

Hello plaisthos,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/877?usp=email

to review the following change.

Change subject: Fix doxygen warnings in crypto_epoch.h
......................................................................

Fix doxygen warnings in crypto_epoch.h

Introduced by commit 92adbc88b1b37095cebde2a1c5b6ae242f382678.

Change-Id I0133085ac68f7b0db574b88276f6d5e1d3ad62d5

---
M src/openvpn/crypto_epoch.h

1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/77/877/1

src/openvpn/crypto_epoch.h +2 -1
index b2f3d86..9290482 100644
@@ -71,7 +71,7 @@
  * Generate a data channel key pair from the epoch key
  * @param key           Destination for the generated data key
  * @param epoch_key     Epoch key to be used
- * @parm kt             Cipher information to generate the data channel key for
+ * @param kt            Cipher information to generate the data channel key for
  */
 void
 epoch_data_key_derive(struct key_parameters *key,
@@ -100,6 +100,7 @@
  * - recv key matches the epoch index provided
  * - send key epoch is equal or higher than recv_key epoch
  *
+ * @param co        crypto_options to update
  * @param new_epoch the new epoch to use for the receive key
  */
 void

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/877?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0133085ac68f7b0db574b88276f6d5e1d3ad62d5
Gerrit-Change-Number: 877
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-MessageType: newchange

#2 lore raw
In reply to a message not in the archive

Attention is currently required from: flichtenheld.

plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/877?usp=email )

Change subject: Fix doxygen warnings in crypto_epoch.h
......................................................................

Patch Set 1: Code-Review+2

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/877?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0133085ac68f7b0db574b88276f6d5e1d3ad62d5
Gerrit-Change-Number: 877
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Wed, 29 Jan 2025 18:24:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

#3 lore raw

PATCH 1/1 Fix doxygen warnings in crypto_epoch.h

In reply to a message not in the archive

From: Frank Lichtenheld <[email protected]...>

Introduced by commit 92adbc88b1b37095cebde2a1c5b6ae242f382678.

Change-Id I0133085ac68f7b0db574b88276f6d5e1d3ad62d5

---

This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/877
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Arne Schwabe <[email protected]...>

src/openvpn/crypto_epoch.h +2 -1
index b2f3d86..9290482 100644
@@ -71,7 +71,7 @@
  * Generate a data channel key pair from the epoch key
  * @param key           Destination for the generated data key
  * @param epoch_key     Epoch key to be used
- * @parm kt             Cipher information to generate the data channel key for
+ * @param kt            Cipher information to generate the data channel key for
  */
 void
 epoch_data_key_derive(struct key_parameters *key,
@@ -100,6 +100,7 @@
  * - recv key matches the epoch index provided
  * - send key epoch is equal or higher than recv_key epoch
  *
+ * @param co        crypto_options to update
  * @param new_epoch the new epoch to use for the receive key
  */
 void
#4 lore raw

[Openvpn-devel] [PATCH applied] Re: Fix doxygen warnings in crypto_epoch.h

Well spotted ;-)

Your patch has been applied to the master branch.

commit b6a2533a3fb29eafe78a2432eaf9adaa0e707420

Author: Frank Lichtenheld
Date:   Wed Jan 29 19:28:18 2025 +0100
     Fix doxygen warnings in crypto_epoch.h

     Signed-off-by: Frank Lichtenheld <[email protected]...>
     Acked-by: Arne Schwabe <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg30731.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering

#5 lore raw
In reply to a message not in the archive

cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/877?usp=email )

The following approvals got outdated and were removed:
Code-Review+2 by plaisthos

Change subject: Fix doxygen warnings in crypto_epoch.h
......................................................................

Fix doxygen warnings in crypto_epoch.h

Introduced by commit 92adbc88b1b37095cebde2a1c5b6ae242f382678.

Change-Id I0133085ac68f7b0db574b88276f6d5e1d3ad62d5

Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg30731.html

---
M src/openvpn/crypto_epoch.h

1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/77/877/2

src/openvpn/crypto_epoch.h +2 -1
index b2f3d86..9290482 100644
@@ -71,7 +71,7 @@
  * Generate a data channel key pair from the epoch key
  * @param key           Destination for the generated data key
  * @param epoch_key     Epoch key to be used
- * @parm kt             Cipher information to generate the data channel key for
+ * @param kt            Cipher information to generate the data channel key for
  */
 void
 epoch_data_key_derive(struct key_parameters *key,
@@ -100,6 +100,7 @@
  * - recv key matches the epoch index provided
  * - send key epoch is equal or higher than recv_key epoch
  *
+ * @param co        crypto_options to update
  * @param new_epoch the new epoch to use for the receive key
  */
 void

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/877?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0133085ac68f7b0db574b88276f6d5e1d3ad62d5
Gerrit-Change-Number: 877
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: newpatchset

#6 lore raw
In reply to a message not in the archive

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/877?usp=email )

Change subject: Fix doxygen warnings in crypto_epoch.h
......................................................................

Fix doxygen warnings in crypto_epoch.h

Introduced by commit 92adbc88b1b37095cebde2a1c5b6ae242f382678.

Change-Id I0133085ac68f7b0db574b88276f6d5e1d3ad62d5

Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg30731.html

---
M src/openvpn/crypto_epoch.h

1 file changed, 2 insertions(+), 1 deletion(-)
src/openvpn/crypto_epoch.h +2 -1
index b2f3d86..9290482 100644
@@ -71,7 +71,7 @@
  * Generate a data channel key pair from the epoch key
  * @param key           Destination for the generated data key
  * @param epoch_key     Epoch key to be used
- * @parm kt             Cipher information to generate the data channel key for
+ * @param kt            Cipher information to generate the data channel key for
  */
 void
 epoch_data_key_derive(struct key_parameters *key,
@@ -100,6 +100,7 @@
  * - recv key matches the epoch index provided
  * - send key epoch is equal or higher than recv_key epoch
  *
+ * @param co        crypto_options to update
  * @param new_epoch the new epoch to use for the receive key
  */
 void

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/877?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0133085ac68f7b0db574b88276f6d5e1d3ad62d5
Gerrit-Change-Number: 877
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: merged